Repository navigation
core: add 'command finished' notifications - #8992
Merged
Merged
Conversation
00-kat
added
os/linux
gui
Member
Author
|
This'll need a macOS implementation since most of the functionality is implemented in the apprt. |
jcollie
force-pushed
the
core-command-finish-notify
branch
from
October 2, 2025 04:59
304b376 to
e7c4350
Compare
mitchellh
requested changes
Oct 2, 2025
mitchellh
left a comment
mitchellh
left a comment
Contributor
There was a problem hiding this comment.
Some fairly simple requests. The big picture design looks good.
Fixes ghostty-org#8991 Uses OSC 133 esc sequences to keep track of how long commands take to execute. If the user chooses, commands that take longer than a user specified limit will trigger a notification. The user can choose between a bell notification or a desktop notification.
jcollie
force-pushed
the
core-command-finish-notify
branch
from
October 2, 2025 17:57
e7c4350 to
1c23ebc
Compare
mitchellh
approved these changes
Oct 3, 2025
Contributor
Did that ever happen? I don't see it in this PR, nor the source tree, nor can I find an issue tracking it. |
Member
Author
Neither has happened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8991
Uses OSC 133 esc sequences to keep track of how long commands take to execute. If the user chooses, commands that take longer than a user specified limit will trigger a notification. The user can choose between a bell notification or a desktop notification.